Code Style: clarify optional whitespace after closing bracket with semicolon#233
Open
Code Style: clarify optional whitespace after closing bracket with semicolon#233
Conversation
Member
|
Hm I think there should be a blank line after this, no? Either way needs the |
jeremypw
reviewed
Sep 8, 2025
| // other code | ||
| ``` | ||
|
|
||
| The placement of empty lines after blocks ending with a closing bracket and semicolon is not regulated. You may add an empty line if it improves readability. |
Collaborator
There was a problem hiding this comment.
Aren't these closing braces, strictly speaking? We need to clarify rules about closing braces and closing brackets as we sometimes have a closing bracket on its own line, e.g for long param list:
long_variable_name = long_function_name (
long_param_name_1,
long_param_name_2,
((a ,b ,c) => {
}
);
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #204