Remove orphaned shape data at boot#3860
Open
magnetised wants to merge 1 commit intomagnetised/shape-db-exclusive-modefrom
Open
Remove orphaned shape data at boot#3860magnetised wants to merge 1 commit intomagnetised/shape-db-exclusive-modefrom
magnetised wants to merge 1 commit intomagnetised/shape-db-exclusive-modefrom
Conversation
magnetised
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## magnetised/shape-db-exclusive-mode #3860 +/- ##
======================================================================
+ Coverage 87.16% 87.20% +0.04%
======================================================================
Files 25 25
Lines 2314 2314
Branches 579 582 +3
======================================================================
+ Hits 2017 2018 +1
+ Misses 295 294 -1
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
magnetised
force-pushed
the
magnetised/shape-db-exclusive-mode
branch
from
2cdda99 to
c8e3cea
Compare
magnetised
force-pushed
the
magnetised/remove-orphaned-shape-data
branch
from
ec1d354 to
81fb9f9
Compare
This comment has been minimized.
This comment has been minimized.
magnetised
force-pushed
the
magnetised/shape-db-exclusive-mode
branch
from
c8e3cea to
75f6997
Compare
magnetised
force-pushed
the
magnetised/remove-orphaned-shape-data
branch
from
81fb9f9 to
aebe6df
Compare
magnetised
force-pushed
the
magnetised/shape-db-exclusive-mode
branch
from
75f6997 to
d8d8e2f
Compare
magnetised
force-pushed
the
magnetised/remove-orphaned-shape-data
branch
from
aebe6df to
868b6d6
Compare
This comment has been minimized.
This comment has been minimized.
magnetised
force-pushed
the
magnetised/shape-db-exclusive-mode
branch
from
d8d8e2f to
12495f2
Compare
magnetised
force-pushed
the
magnetised/remove-orphaned-shape-data
branch
from
868b6d6 to
80a9aa2
Compare
If the number of valid shapes is 0, then just efficiently remove the shape data directory entirely, forcing a re-creation. In the case of an ephemeral shape db this will reset the shape data alongside the reset of the shape db.
magnetised
force-pushed
the
magnetised/shape-db-exclusive-mode
branch
from
12495f2 to
59ba3da
Compare
magnetised
force-pushed
the
magnetised/remove-orphaned-shape-data
branch
from
80a9aa2 to
90e81f6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the number of valid shapes is 0, then just efficiently remove the shape data directory entirely, forcing a re-creation. In the case of an ephemeral shape db this will reset the shape data alongside the reset of the shape db.