fix(sync-service): Prevent negative replication lag statistics#3795
Merged
magnetised merged 1 commit intomainfrom Feb 23, 2026
Merged
fix(sync-service): Prevent negative replication lag statistics#3795magnetised merged 1 commit intomainfrom
magnetised merged 1 commit intomainfrom
Conversation
✅ Deploy Preview for electric-next ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3795 +/- ##
=======================================
Coverage 87.06% 87.06%
=======================================
Files 25 25
Lines 2343 2343
Branches 592 595 +3
=======================================
Hits 2040 2040
Misses 301 301
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
magnetised
force-pushed
the
magnetised/receive-lag-clockskew
branch
from
bb120cb to
7de2f88
Compare
Detect clock skew that presents as transaction commit timestamps being after the current system time and use the diff in the final replication lag calculation. As noted this removes information but in the presence of detectable clock skew this information is unhelpful. Clock skew make a mockery of our idea that the replication lag calculation in any way represents the actual time between a commit in pg and a write in electric. With this at least we get an end to end time for the processing of a transaction and can monitor trends.
magnetised
force-pushed
the
magnetised/receive-lag-clockskew
branch
from
7de2f88 to
7067f48
Compare
This comment has been minimized.
This comment has been minimized.
Contributor
|
This PR has been released! 🚀 The following packages include changes from this PR:
Thanks for contributing to Electric! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Detect clock skew that presents as transaction commit timestamps being after the current system time and use the diff in the final replication lag calculation.
As noted this removes information but in the presence of detectable clock skew this information is unhelpful.
Clock skew make a mockery of our idea that the replication lag calculation in any way represents the actual time between a commit in pg and a write in electric. With this at least we get an end to end time for the processing of a transaction and can monitor trends.