Require repo commands in workflow prompts#141
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
❌ Author of the following commits did not sign a Contributor Agreement: Please, read and sign the above mentioned agreement if you want to contribute to this project |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
REQUEST_CHANGES.
What is this? | From workflow: PR Review Agent
Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. for issue #141
| - **CAN**: Read files, search code, modify files locally, run tests and commands, comment on PRs, push changes to same-repo PR branches | ||
| - **CANNOT**: Push to fork PR branches, merge PRs, or modify `.github/workflows/` | ||
|
|
||
| When pushing changes, the workspace already has the PR branch checked out. Make your changes, run required repo commands (lint/build/test) relevant to the fix, commit them locally, then use `push_to_pull_request_branch`. |
There was a problem hiding this comment.
[MEDIUM] Missing guidance for unavailable required commands
This workflow tells the agent to run required repo commands before pushing, but it doesn’t say how to determine which commands are required or what to do if they can’t be run. Other code-changing prompts explicitly require identifying commands from README/CONTRIBUTING/DEVELOPING/Makefile/CI config and skipping the push (with an explanation) if required commands can’t run; adding the same guidance here would satisfy the issue requirement and prevent untested fixes from being pushed.
|
CI failed in The PR only adds the new prompt files under github/workflows/gh-aw-code-simplifier.md
1: ---
2: description: "Simplify overcomplicated code with high-confidence refactors"
3: imports:
4: - gh-aw-fragments/elastic-tools.md
5: - gh-aw-fragments/runtime-setup.md
6: - gh-aw-fragments/formatting.mdFix: move the six Tests: not run locally (CI failed at compile step). What is this? | From workflow: PR Checks Fixer Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
|
Summary:
Fix applied (per workflow-edit guardrails):
Tests:
What is this? | From workflow: PR Checks Fixer Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
|
Summary: the compile step fails on schema validation because Fix staged (cannot update github/workflows/gh-aw-agent-suggestions.md:L48-L57
```yaml
network:
allowed:
- defaults
- github
- go
- node
- python
- ruby
strict: false
```github/workflows/gh-aw-semantic-function-clustering.md:L54-L59
```yaml
tools:
serena: ["go", "python", "typescript", "java", "csharp", "rust"]
```Next steps: move the updated copies from Tests: not run (workflow edits/compile would modify What is this? | From workflow: PR Checks Fixer Give us feedback! React with 🚀 if perfect, 👍 if helpful, 👎 if not. |
1 participant
Summary:
Implementation note:
github/workflows/as copies of.github/workflows/gh-aw-*.mdper workflow-editing guardrails in this environment. Please move these files into.github/workflows/and runmake compileto regenerate the.lock.ymlworkflows.Testing:
Not run (prompt-only changes; compile skipped per workflow edit guardrail).
Fixes Ensure code workflows run required commands #135