-
Notifications
You must be signed in to change notification settings - Fork 6
feat: support apptainer (in particular avoid warnings) #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
32b8dd1 to
7d68306
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds support for Apptainer to prevent warnings when SINGULARITY_* and APPTAINER_* environment variables differ. The changes prioritize Apptainer over Singularity when both are available, set corresponding APPTAINER_* environment variables alongside existing SINGULARITY_* variables, and update user-facing messages and documentation to reflect support for both tools.
Changes:
- Added APPTAINER_TMPDIR and APPTAINER_BINDPATH environment variable exports
- Modified binary detection logic to prefer Apptainer over Singularity
- Updated error messages, help text, and comments to reference Apptainer alongside Singularity
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Dmitry Kalinkin <dmitry.kalinkin@gmail.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
d5d6068 to
e875bf6
Compare
Briefly, what does this PR introduce?
Apptainer warns when SINGULARITY_* and APPTAINER_* variables are different. This will make the user experience smoother with fewer warnings.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
No.