Skip to content

Fix OmegaFormStuff _tag required #472

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MindfulLearner wants to merge 2 commits into
base: main
Choose a base branch
from
+14 −8
Open

Fix OmegaFormStuff _tag required #472

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
71fafb4
test clear it works
MindfulLearner Oct 22, 2025
b592cb5
Merge remote-tracking branch 'origin/main' into fix/OmegaFormStuff-_t…
MindfulLearner Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions packages/vue-components/src/components/OmegaForm/OmegaFormStuff.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,11 @@ export const createMeta = <T = any>(
const nullableOrUndefined = isNullableOrUndefined(p.type)
const isRequired = !nullableOrUndefined

// check if parent is nullOr and set meta as not required
const parentNullableOrFalse = meta.nullableOrUndefined ?? false
// return a true or false
const finalIsRequired = parentNullableOrFalse ? false : isRequired

const typeToProcess = p.type
if (S.AST.isUnion(p.type)) {
// First unwrap any nested unions, then filter out null/undefined
Expand All @@ -367,7 +372,7 @@ export const createMeta = <T = any>(
const parentMeta = createMeta<T>({
parent: key,
property: p.type,
meta: { required: isRequired, nullableOrUndefined }
meta: { required: finalIsRequired, nullableOrUndefined }
})
acc[key as NestedKeyOf<T>] = parentMeta as FieldMeta
}
Expand All @@ -380,7 +385,7 @@ export const createMeta = <T = any>(
createMeta<T>({
parent: key,
propertySignatures: nonNullType.propertySignatures,
meta: { required: isRequired, nullableOrUndefined }
meta: { required: finalIsRequired, nullableOrUndefined }
})
)
}
Expand All @@ -395,7 +400,7 @@ export const createMeta = <T = any>(
type: "multiple",
members: arrayType.elements,
rest: arrayType.rest,
required: isRequired,
required: finalIsRequired,
nullableOrUndefined
} as FieldMeta

Expand Down Expand Up @@ -456,7 +461,7 @@ export const createMeta = <T = any>(
const newMeta = createMeta<T>({
parent: key,
property: p.type,
meta: { required: isRequired, nullableOrUndefined }
meta: { required: finalIsRequired, nullableOrUndefined }
})
acc[key as NestedKeyOf<T>] = newMeta as FieldMeta
}
Expand All @@ -467,7 +472,7 @@ export const createMeta = <T = any>(
createMeta<T>({
parent: key,
propertySignatures: typeToProcess.propertySignatures,
meta: { required: isRequired, nullableOrUndefined }
meta: { required: finalIsRequired, nullableOrUndefined }
})
)
} else {
Expand Down Expand Up @@ -532,7 +537,7 @@ export const createMeta = <T = any>(
type: "multiple",
members: p.type.elements,
rest: p.type.rest,
required: isRequired,
required: finalIsRequired,
nullableOrUndefined
} as FieldMeta
}
Expand All @@ -543,7 +548,7 @@ export const createMeta = <T = any>(
meta: {
// an empty string is valid for a S.String field, so we should not mark it as required
// TODO: handle this better via the createMeta minLength parsing
required: isRequired && (p.type._tag !== "StringKeyword" || getMetadataFromSchema(p.type).minLength),
required: finalIsRequired && (p.type._tag !== "StringKeyword" || getMetadataFromSchema(p.type).minLength),
nullableOrUndefined
}
})
Expand Down
3 changes: 2 additions & 1 deletion packages/vue-components/stories/OmegaForm/Union.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,8 @@ class B extends S.TaggedClass<B>()("B", {
const schema = S
.Struct({
title: S.String,
union: S.Union(A, B)
// testing it works! union is nullable no asterisk showed
union: S.NullOr(S.Union(A, B))
Copy link
Member

@patroza patroza Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it allows null id expect also to find a select entry representing null, so you can test and confirm the null case works as expected

})

const defaultValues: typeof schema.Encoded = {
Expand Down
Loading