Skip to content

refactor(ampd): standardize env var names with AMP_prefix#1702

Open
mitchhs12 wants to merge 4 commits intomainfrom
standardize-ampd-env-vars
Open

refactor(ampd): standardize env var names with AMP_prefix#1702
mitchhs12 wants to merge 4 commits intomainfrom
standardize-ampd-env-vars

Conversation

@mitchhs12
Copy link
Contributor

@mitchhs12 mitchhs12 commented Feb 5, 2026

Standardizes ampd environment variable naming to use consistent AMP_* prefix for all CLI options.

Changes

  • Renamed environment variables:

    • FLIGHT_SERVERAMP_FLIGHT_SERVER
    • JSONL_SERVERAMP_JSONL_SERVER
    • ADMIN_SERVERAMP_ADMIN_SERVER
  • Add deprecation migration at startup that:

    • Copies old env var values to new names
    • Emits warning to stderr for each deprecated var
  • Update OpenCLI spec documentation

  • Add upgrade guide entry for users

Note: Deprecation warnings use eprintln! because this runs before tracing is initialized (before clap parsing).

Backward Compatibility

  • Old environment variable names continue to work but emit deprecation warnings. No breaking changes - users can migrate at their own pace.

Closes #1692

@mitchhs12 mitchhs12 self-assigned this Feb 5, 2026
@mitchhs12
Copy link
Contributor Author

Not sure whether the deprecation notice for this should be in the upgrading.md file.

How long should we keep this in here?

@mitchhs12 mitchhs12 requested review from LNSD and shiyasmohd February 5, 2026 18:38
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should update the feature docs for ampd too. To reflect the new env variable names.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Homogenize ampd configuration: env vars and config

2 participants