refactor(ampd): standardize env var names with AMP_prefix#1702
Open
refactor(ampd): standardize env var names with AMP_prefix#1702
Conversation
Contributor
Author
|
Not sure whether the deprecation notice for this should be in the How long should we keep this in here? |
LNSD
reviewed
Feb 5, 2026
LNSD
reviewed
Feb 5, 2026
Contributor
There was a problem hiding this comment.
You should update the feature docs for ampd too. To reflect the new env variable names.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardizes
ampdenvironment variable naming to use consistentAMP_*prefix for all CLI options.Changes
Renamed environment variables:
FLIGHT_SERVER→AMP_FLIGHT_SERVERJSONL_SERVER→AMP_JSONL_SERVERADMIN_SERVER→AMP_ADMIN_SERVERAdd deprecation migration at startup that:
Update OpenCLI spec documentation
Add upgrade guide entry for users
Note: Deprecation warnings use
eprintln!because this runs before tracing is initialized (before clap parsing).Backward Compatibility
Closes #1692