Skip to content

Conversation

@TejInaco
Copy link
Contributor

@TejInaco TejInaco commented Dec 9, 2025

This PR will introduce a new feature:

  • Non-mandatory gateway validation: Users can now submit workflow contributions to the catalog without specifying gateway values in the Interaction

Also, will introduce refactoring in the structure, mainly:

  • Refactored form components to maintain structural consistency, improve code organization and reused of subcomponents, decrease the DOM duplication
  • Enhanced TypeScript type checking

Attention: BREAKING CHANGES
Closes #165

@netlify
Copy link

netlify bot commented Dec 9, 2025

Deploy Preview for editdor ready!

Name Link
🔨 Latest commit db805ad
🔍 Latest deploy log https://app.netlify.com/projects/editdor/deploys/694ec05833c2840008783fe9
😎 Deploy Preview https://deploy-preview-170--editdor.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@TejInaco TejInaco changed the title feat add validation getjsonldstring for typescript feat non mandatory validation on gateway Dec 9, 2025
@TejInaco TejInaco force-pushed the feat-delete-validation-on-gateway branch from 160ce05 to ab515aa Compare December 19, 2025 23:40
Signed-off-by: Ricardo Silva <rephyrus0877@protonmail.com>
Signed-off-by: Ricardo M G da Silva <rephyrus0877@protonmail.com>
Signed-off-by: Ricardo M G da Silva <rephyrus0877@protonmail.com>
Signed-off-by: Ricardo M G da Silva <rephyrus0877@protonmail.com>
Signed-off-by: Ricardo M G da Silva <rephyrus0877@protonmail.com>
Signed-off-by: Ricardo M G da Silva <rephyrus0877@protonmail.com>
@TejInaco TejInaco force-pushed the feat-delete-validation-on-gateway branch from ab515aa to 7712f92 Compare December 19, 2025 23:46
Signed-off-by: Ricardo Silva <rephyrus0877@protonmail.com>
Signed-off-by: Ricardo Silva <rephyrus0877@protonmail.com>
@egekorkan
Copy link
Contributor

It still doesn't work end to end, please test it end to end with http://plugfest.thingweb.io/http-data-schema-thing without the endpoint and turning @type into "tm:ThingModel". Now, the values are read but the generated TM does not have @type somehow?

Signed-off-by: Ricardo Silva <rephyrus0877@protonmail.com>
@TejInaco
Copy link
Contributor Author

It still doesn't work end to end, please test it end to end with http://plugfest.thingweb.io/http-data-schema-thing without the endpoint and turning @type into "tm:ThingModel". Now, the values are read but the generated TM does not have @type somehow?

As requested, now all necessary transformations of the TD will happen when the user clicks the "Validation" button and will generate the final Thing Model, that is on the first window of the workflow "Contribute to Catalog". So now when the user opens the "Contributes to Catalog" the changes in the TM can be:

  1. Author
  2. Model
  3. Manufacturer
  4. License
  5. Copyright Year
  6. Copyright Holder
  7. ID is modified to match "urn:" previously was in the table view
  8. Normalize context

Previous transformations on the TM on the keys "@type" and "tm:required" were dropped.

In case of placeholders ( e.g {{host}} ) in the TM will not be changed, however a temporary TM is created to test the values of the placeholders in the second view of the workflow "Contribute to Catalog".

Signed-off-by: Ricardo Silva <rephyrus0877@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TM Contribution Workflow should not require a gateway

2 participants