statesysten: add processSpanStateChange function to statesystem #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
*A new function (processSpanStateChange) is added to the TransientState class. Because in async traces unlike sync traces, the position of the event in fOngoingInfo is not the same as the quark of the event in the call stack. So we should pass two integer, quark and callstack quark to the function. * the Statesystem and ItmfStateSystem classes are changed relayed to this function. Signed-off-by: Fariba Daneshgar <faraji.daneshgar@gmail.com>
MatthewKhouzam
requested changes
Mar 20, 2024
Contributor
MatthewKhouzam
left a comment
MatthewKhouzam
left a comment
There was a problem hiding this comment.
Transient State is an implementation of the API. Are we certain we want to add an API for this feature? It seems... like everything else will need to implement "unsupported" though it's designed for one implementation.
| } | ||
|
|
||
| /** | ||
| * @param t |
| * @throws StateValueTypeException | ||
| */ | ||
| @Override | ||
| public void modifySpanAttribute(long t, Object value, int attributeQuark, int spanQuark) |
Contributor
There was a problem hiding this comment.
Span is not a state system notion, it's a contextual interval. Should we bring it down to this level of abstraction?
| long start, long end) throws StateSystemDisposedException, IndexOutOfBoundsException, TimeRangeException; | ||
|
|
||
| /** | ||
| * @param t |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new function (processSpanStateChange) is added to the TransientState class. Because in async traces unlike sync traces, the position of the event in fOngoingInfo is not the same as the quark of the event in the call stack. So we should pass two integer, quark and callstack quark to the function.
The Statesystem and ItmfStateSystem classes are changed relayed to this function.
this changes is for adding flamgraph analysis for opentracing