Skip to content

Conversation

@adaussy
Copy link
Contributor

@adaussy adaussy commented Jan 23, 2026

PLEASE READ ALL ITEMS AND CHECK ONLY RELEVANT CHECKBOXES BELOW

Auto review

  • Have you reviewed this PR? Please do a first quick review, It is very useful to detect typos and missing copyrights, check comments, check your code... The reviewer will thank you for that :)

Project management

  • Has the pull request been added to the relevant milestone?
  • Have the priority: and pr: labels been added to the pull request? (In case of doubt, start with the labels priority: low and pr: to review later)
  • Have the relevant issues been added to the pull request?
  • Have the relevant labels been added to the issues? (area:, type:)
  • Have the relevant issues been added to the same project milestone as the pull request?

Changelog and release notes

  • Has the CHANGELOG.adoc + doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc been updated to reference the relevant issues?
  • Have the relevant API breaks been described in the CHANGELOG.adoc?
  • Are the new / upgraded dependencies mentioned in the relevant section of the CHANGELOG.adoc?
  • In case of a change with a visual impact, are there any screenshots in the doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?
  • In case of a key change, has the change been added to Key highlights section in doc/content/modules/user-manual/pages/release-notes/YYYY.MM.0.adoc?

Documentation

  • Have you included an update of the documentation in your pull request? Please ask yourself if an update (installation manual, user manual, developer manual...) is needed and add one accordingly.

Tests

  • Is the code properly tested? Any pull request (fix, enhancement or new feature) should come with a test (or several). It could be unit tests, integration tests or cypress tests depending on the context. Only doc and releng pull request do not need for tests.

@adaussy adaussy changed the base branch from main to cooldown January 23, 2026 14:34
@adaussy adaussy changed the title Ada/fix/1887 [1887] Export fails to escape some names when using qualified name Jan 23, 2026
@AxelRICHARD AxelRICHARD added this to the 2026.3.0 milestone Jan 23, 2026
@AxelRICHARD AxelRICHARD linked an issue Jan 23, 2026 that may be closed by this pull request
@adaussy adaussy force-pushed the ada/fix/1887 branch 5 times, most recently from f4a4835 to 762232d Compare January 26, 2026 08:51
@AxelRICHARD
Copy link
Member

AxelRICHARD commented Jan 26, 2026

could you please auto-review your PR as asked by the PR template?

Signed-off-by: Arthur Daussy <arthur.daussy@obeo.fr>
Bug: eclipse-syson#1887
@adaussy
Copy link
Contributor Author

adaussy commented Jan 26, 2026

could you please auto-review your PR as asked by the PR template?

Done with rebase

@AxelRICHARD AxelRICHARD merged commit 9203957 into eclipse-syson:cooldown Jan 26, 2026
2 of 3 checks passed
@adaussy adaussy deleted the ada/fix/1887 branch January 26, 2026 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Export fails to escape some names when using qualified name

2 participants