Make MarkerTest properly handle asynchronous change listener #106 #2374
+15
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…platform#106 The MarkerTest implementations currently assume that resource change listeners are notifies synchronously about changes due to modified markers. This assumption is not correct and leads to several race conditions in the tests which can make them fail sporadically. This change adapts the MarkerTests to properly handle asynchronous execution of resource change listeners: - Wait until a timeout for the number of expected resource changes being processed by the used resource change listener - Make the data structures inside the resource listeners thread safe Fixes eclipse-platform#106
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MarkerTest implementations currently assume that resource change listeners are notifies synchronously about changes due to modified markers. This assumption is not correct and leads to several race conditions in the tests which can make them fail sporadically.
This change adapts the MarkerTests to properly handle asynchronous execution of resource change listeners:
Fixes #106