Skip to content

Search filter showing only deepest match should't filter closed projects#3753

Merged
merks merged 2 commits intoeclipse-platform:masterfrom
merks:pr-fix-nested-project-search-filter
Feb 28, 2026
Merged

Search filter showing only deepest match should't filter closed projects#3753
merks merged 2 commits intoeclipse-platform:masterfrom
merks:pr-fix-nested-project-search-filter

Conversation

@merks
Copy link
Contributor

@merks merks commented Feb 28, 2026

  • A closed project's content cannot be searched so matches attributed to a closed nested project should not filter the corresponding match from the outer project otherwise you can get very confusing results like showing 0 of 1 matches.
  • Fix action label which is shown on a menu to be title case.

- A closed project's content cannot be searched so matches attributed to
a closed nested project should not filter the corresponding match from
the outer project otherwise you can get very confusing results like
`showing 0 of 1 matches`.
- Fix action label which is shown on a menu to be title case.
@merks
Copy link
Contributor Author

merks commented Feb 28, 2026

In this simple case, without the fix, the only match is filtered from the view

image

With the fix, including the title case action label it works properly:

image

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.search/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 3d4c5c6de12ad0def756b285a1e274ea67743f8e Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <platform-bot@eclipse.org>
Date: Sat, 28 Feb 2026 08:08:55 +0000
Subject: [PATCH] Version bump(s) for 4.40 stream


diff --git a/bundles/org.eclipse.search/META-INF/MANIFEST.MF b/bundles/org.eclipse.search/META-INF/MANIFEST.MF
index ce93222915..c02b8b90b7 100644
--- a/bundles/org.eclipse.search/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.search/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.search; singleton:=true
-Bundle-Version: 3.18.0.qualifier
+Bundle-Version: 3.18.100.qualifier
 Bundle-Activator: org.eclipse.search.internal.ui.SearchPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
-- 
2.53.0

Further information are available in Common Build Issues - Missing version increments.

@github-actions
Copy link
Contributor

Test Results

 3 024 files  +2   3 024 suites  +2   2h 11m 10s ⏱️ + 2m 6s
 8 234 tests ±0   7 986 ✅ ±0  248 💤 ±0  0 ❌ ±0 
23 526 runs  +1  22 735 ✅ +1  791 💤 ±0  0 ❌ ±0 

Results for commit a39b910. ± Comparison against base commit 5c5b3c2.

@merks merks merged commit e6d3cbf into eclipse-platform:master Feb 28, 2026
18 checks passed
@merks merks deleted the pr-fix-nested-project-search-filter branch February 28, 2026 09:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants