Migrate WorkbenchContextRule to WorkbenchContextExtension and update … #3635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test Results 3 015 files 3 015 suites 2h 16m 48s ⏱️ Results for commit 0055b14. ♻️ This comment has been updated with latest results. |
…tests 1. Created WorkbenchContextExtension as a JUnit 5 replacement for WorkbenchContextRule. 2. Updated MANIFEST.MF to include org.junit.jupiter.api.extension in Import-Package. 3. Migrated CompositePartClosingTest, MSaveablePartTest, ModelServiceImplTest, MMenuItemTest, and MToolItemTest to JUnit 5. 4. Verified all migrated tests pass via Maven Tycho.
vogella
force-pushed
the
migrate-context-rule
branch
from
88ec260 to
0055b14
Compare
Contributor
Author
|
LGTM, planning to merge today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…tests