Skip to content

Mark ImageDataAtSizeProvider as referenceable #2922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
arunjose696 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Mark ImageDataAtSizeProvider as referenceable #2922

arunjose696 wants to merge 1 commit into from
+72 −2

Conversation

@arunjose696
Copy link
Contributor

@arunjose696 arunjose696 commented Dec 30, 2025

No description provided.

@arunjose696 arunjose696 linked an issue Dec 30, 2025 that may be closed by this pull request
Mark ImageDataAtSizeProvider as referencable and add N&N for ImageDataAtSizeProvider vi-eclipse/Eclipse-Platform#473
Open
@github-actions
Copy link
Contributor

github-actions bot commented Dec 30, 2025 •
edited
Loading

Test Results

156 files   -    20  156 suites   - 20   11s ⏱️ - 26m 3s
 84 tests  - 4 588   84 ✅  - 4 566  0 💤  - 22  0 ❌ ±0 
370 runs   -   112  370 ✅  -   106  0 💤  -  6  0 ❌ ±0 

Results for commit 845a9b3. ± Comparison against base commit 383ed2a.

This pull request removes 4588 tests. 
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_dollarSign
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_emptyString
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_letterA
AllGTKTests Test_GtkConverter ‑ test_HeuristicASCII_letters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16LE_null
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_AsciiLetters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_Asciiletter
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_LotsOfLetters
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_letter
AllGTKTests Test_GtkConverter ‑ test_HeuristicUTF16_letters
…

♻️ This comment has been updated with latest results.

@arunjose696 arunjose696 force-pushed the arunjose696/ImageDataAtSizeProviderReferencable branch from 3ff2114 to ad26c15 Compare December 30, 2025 16:17
akurtakov
akurtakov reviewed Dec 30, 2025
View reviewed changes
binaries/org.eclipse.swt.win32.win32.x86_64/META-INF/MANIFEST.MF Outdated
Bundle-Vendor: %providerName
Bundle-SymbolicName: org.eclipse.swt.win32.win32.x86_64; singleton:=true
Bundle-Version: 3.133.0.qualifier
Bundle-Version: 4.0.0.qualifier
Copy link
Member

@akurtakov akurtakov Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fragments and host in SWT should match version. We are not moving to 4.0 for this one. Please add API tools commented API filter.

Copy link
Contributor Author

@arunjose696 arunjose696 Dec 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the commented API filter. from the eclipse quickfix does not seem to work, Can you give an example how to add the API filter, making a class referenceable

akurtakov
akurtakov requested changes Dec 30, 2025
View reviewed changes
...les/org.eclipse.swt/Eclipse SWT/common/org/eclipse/swt/graphics/ImageDataAtSizeProvider.java Outdated
* @since 3.132
* @noreference This class is still experimental API and might be subject to
* change.
* @since 4.0
Copy link
Member

@akurtakov akurtakov Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since flag should not change. Just the noreference to be dropped.

Copy link
Contributor Author

@arunjose696 arunjose696 Dec 30, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

my IDE complains when this is done , Let me see if the CI works
image

Copy link
Contributor

@HeikoKlare HeikoKlare Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have the right baseline set in your IDE? It looks a bit odd that the generated filter references 3.131.0:

                <message_argument value="3.133.0"/>
                <message_argument value="3.131.0"/>

Maybe you have an outdated setup? You should do a "Perform Setup Tasks" and check you API baseline for if it contains the right SWT reference version (should be 3.132.0):
image

@arunjose696 arunjose696 force-pushed the arunjose696/ImageDataAtSizeProviderReferencable branch 3 times, most recently from 062c96b to 50b1d80 Compare December 31, 2025 12:12
@arunjose696 arunjose696 mentioned this pull request Dec 31, 2025
Open
@arunjose696 arunjose696 force-pushed the arunjose696/ImageDataAtSizeProviderReferencable branch 2 times, most recently from c48c783 to 4a5b73f Compare December 31, 2025 15:09
@arunjose696 arunjose696 force-pushed the arunjose696/ImageDataAtSizeProviderReferencable branch from 4a5b73f to 845a9b3 Compare December 31, 2025 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@HeikoKlare HeikoKlare HeikoKlare left review comments

@akurtakov akurtakov akurtakov requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Mark ImageDataAtSizeProvider as referencable and add N&N for ImageDataAtSizeProvider

3 participants

@arunjose696 @akurtakov @HeikoKlare