Skip to content
This repository was archived by the owner on Jan 17, 2025. It is now read-only.

Conversation

@R2-t
Copy link
Contributor

@R2-t R2-t commented May 10, 2023

Description

Standard virtual environment across all developers is crucial to easily clone the repo and add new changes. Pipenv offers virtual environment management without much cost.

Requirements

  • Standardize virtual environment in python-sdk

Motivation and Context

Facilitate dependencies to contributors by establishing a common pattern in managing virtual environments.

Link to the task on Jira

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Code Review

  • PR requires a team code review.

@R2-t R2-t requested a review from a team as a code owner May 10, 2023 18:24
@thenewlebowski
Copy link
Member

can we dump the requirements.txt since we are using pipenv now?

@R2-t
Copy link
Contributor Author

R2-t commented May 11, 2023

can we dump the requirements.txt since we are using pipenv now?

I will have to investigate that, because we use it to publish the library to PyPi

@grantula
Copy link

grantula commented Jun 15, 2023

Hello folks! I still check in on this repo from time to time 😜

If you wanted to nix the requirements.txt file you could do the following:

Currently in setup.py:

with open('requirements.txt') as f:
    requirements = f.read().splitlines()

instead you could do this:

from pipfile import Pipfile

...

parsed = Pipfile("./Pipfile").load()
requirements = [f"{k}{v}" for k, v in parsed.data["default"].items()]

@TheHatchetteMan
Copy link
Contributor

@Santiago-Torres14 what are we doing with this one?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants