Skip to content

Fix Application Layout Code Table #2366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jialecl merged 4 commits into from
Dec 10, 2025
Merged

Fix Application Layout Code Table #2366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
036475b
Fix appLayout Footer prop Description
PelayoFelgueroso Dec 10, 2025
fae26b1
Fix header prop description
PelayoFelgueroso Dec 10, 2025
e9df9da
Add default value to logo prop in footer component
PelayoFelgueroso Dec 10, 2025
1dad952
Merge branch 'master' into PelayoFelgueroso/appLayout-code_footer
Jialecl Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions apps/website/screens/components/application-layout/code/ApplicationLayoutCodePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ const ApplicationLayoutPropsTable = () => (
</td>
<td>
Footer of the application layout shown at the bottom of the screen. It is optional and if it is not specified,
the default header will be shown. Please check the Footer documentation{" "}
the default footer will be shown. Please check the Footer documentation{" "}
<Link href="/components/footer" passHref legacyBehavior>
<DxcLink>here</DxcLink>
</Link>
Expand All @@ -60,7 +60,7 @@ const ApplicationLayoutPropsTable = () => (
</td>
<td>
Header of the application layout shown at the top of the screen. It is optional and if it is not specified,
the default header will be shown. Please check the Header documentation{" "}
the header will not be shown. Please check the Header documentation{" "}
<Link href="/components/header" passHref legacyBehavior>
<DxcLink>here</DxcLink>
</Link>
Expand Down
9 changes: 8 additions & 1 deletion apps/website/screens/components/footer/code/FooterCodePage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,11 @@ const socialLinkTypeString = `{
logo: string | SVG;
}[]`;

const defaultFooterLogo = `{
src: DxcLogo,
alt: "DXC Technology Logo"
}`;

const sections = [
{
title: "Props",
Expand Down Expand Up @@ -85,7 +90,9 @@ const sections = [
<ExtendedTableCode>{logoTypeString}</ExtendedTableCode>
</td>
<td>Logo to be displayed inside the footer.</td>
<td>-</td>
<td>
<ExtendedTableCode>{defaultFooterLogo}</ExtendedTableCode>
</td>
</tr>
<tr>
<td>mode</td>
Expand Down