Merged
Conversation
🦋 Changeset detectedLatest commit: e29b46b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for react-github-permalink ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Fix syntax highlighting for React/TypeScript files by adding language detection Co-authored-by: dwjohnston <2467377+dwjohnston@users.noreply.github.com> Add React TSX syntax highlighting demo story and verify fix works Co-authored-by: dwjohnston <2467377+dwjohnston@users.noreply.github.com> Sample tsx Just don't set the language Get rid of 'getLanguageFromPath' stuff
dwjohnston
force-pushed
the
human/fix-53-syntax-highlighting
branch
from
3355328 to
e53808d
Compare
✅ Deploy Preview for react-github-permalink ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
… detection Co-authored-by: dwjohnston <2467377+dwjohnston@users.noreply.github.com>
dwjohnston
force-pushed
the
human/fix-53-syntax-highlighting
branch
from
7337d25 to
48dfb21
Compare
dwjohnston
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix syntax highlighting issue by auto detecting language based on file extension.
This is a somewhat naive approach, but works for now.
Also, have switched to Prism of HLJS as Prism supports TSX, JSX.
Worth considering approaches mentioned in this thread for more comprehensive language detection.
PrismJS/prism#1313