[CoW Protocol] Update CoW Protocol Solvers #9165
Open
+24
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
WIP
PR SummaryUpdates
Written by Cursor Bugbot for commit a681219. Configure here. |
github-actions
bot
added
ready-for-review
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| (0xCcEa0a350aE1734A10981A2aA45D1A9a5fDfaDe3, 'barn', 'Piggy'), | ||
| (0x568868a02aff3765CFCebBF13FF4A3A7fec7f7d5, 'prod', 'Piggy') | ||
| (0x568868a02aff3765CFCebBF13FF4A3A7fec7f7d5, 'prod', 'Piggy'), | ||
| (0x3980daa7eaad0b7e0c53cfc5c2760037270da54d, 'prod', 'TSolver') |
There was a problem hiding this comment.
Inconsistent solver name casing 'TSolver' vs 'Tsolver'
The newly added entry for address 0x3980daa7eaad0b7e0c53cfc5c2760037270da54d uses 'TSolver' (capital T and S), but this same address is named 'Tsolver' in all other network files (Arbitrum, Base, BNB, Ethereum, Polygon) and in the same Avalanche file at lines 46 and 60. This naming inconsistency will cause data quality issues when aggregating solver metrics across networks or within Avalanche, as queries filtering by solver name will miss this entry.
bram-vdberg
force-pushed
the
Update-Spellbook-Solvers
branch
from
a681219 to
37589f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates the solvers for CoW protocol to add some new solvers for all networks.