[PySpark] - Add partial support for window function#318
Open
mariotaddeucci wants to merge 4 commits intoduckdb:mainfrom
Open
[PySpark] - Add partial support for window function#318mariotaddeucci wants to merge 4 commits intoduckdb:mainfrom
mariotaddeucci wants to merge 4 commits intoduckdb:mainfrom
Conversation
mariotaddeucci
changed the title
… for ContributionsAcceptedError message regex
Author
|
I don't know how but the next step is to implement proper handling of Column expressions in ordering (including asc/desc). |
mariotaddeucci
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial support for window functions by introducing a PySpark-like
WindowAPI and aWindowSpecclass.The implementation is partial: partitioning, basic ordering-by-names, and frame specification (rowsBetween / rangeBetween) are supported and converted to SQL window clauses, but extracting ordering direction from Column expressions is not yet implemented (see the TODO in WindowSpec._columns_as_str). Using Column expressions in orderBy currently raises a
ContributionsAcceptedError.Additionally, a set of functions was added for convenient use with .over(window):