Skip to content

Fix typo in xml_tools TODO and update CONTRIBUTING.md #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
GangGreenTemperTatum merged 1 commit into from
Feb 18, 2026
Merged

Fix typo in xml_tools TODO and update CONTRIBUTING.md #343

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions .github/CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ We actively welcome your pull requests.
3. If you've changed APIs, update the documentation.
4. Ensure the test suite passes.
5. Make sure your code lints.
6. If you haven't already, complete the Contributor License Agreement ("CLA").

### PR Description Format

Expand Down Expand Up @@ -54,13 +53,6 @@ Example:
- Deprecated setup scripts
```

## Contributor License Agreement ("CLA")

In order to accept your pull request, we need you to submit a CLA. You only need
to do this once to work on any of Facebook's open source projects.

Complete your CLA here: <https://code.facebook.com/cla>

## Issues

We use GitHub issues to track public bugs. Please ensure your description is
Expand Down
2 changes: 1 addition & 1 deletion rigging/transform/xml_tools.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ async def xml_to_tools_transform(chat: "Chat") -> "Chat": # noqa: PLR0912
message.remove_slices(XmlToolCall)

# Convert our tool responses
# TODO: handle cased where multiple tool responses are present
# TODO: handle cases where multiple tool responses are present

for message in chat.all:
if (tool_response := message.try_parse(ToolResponse)) is None:
Expand Down