Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, this library applies filtering/smoothing for values on Android devices, but does not (yet) apply filtering/smoothing for iOS devices. As a result, behavior seems inconsistent across platforms.
This PR normalizes smoothing/filtering, so that it is handled the same way across both platforms.
It provides two related methods:
... and employs the pre-existing default filtering value/equation for Android, i.e: smoothed = 0.3*new + (1.0 - 0.3)*old
This PR includes the changes of PR #4, enabling this library to be used in typescript react-native projects.