Move TestAccessors to extension properties #14134
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaner syntax. Also update exception handling to be more useful. This is to better align with what I'm putting in the SDK repo. Hopefully I can eventually move this upstream to some of our shared test infra. It does make it a little bit more awkward for VB, but not unusable.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #14134 +/- ##
====================================================
+ Coverage 77.15337% 97.40559% +20.25222%
====================================================
Files 3279 1214 -2065
Lines 645325 357384 -287941
Branches 47720 5597 -42123
====================================================
- Hits 497890 348112 -149778
+ Misses 143748 8480 -135268
+ Partials 3687 792 -2895
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaner syntax. Also update exception handling to be more useful.
This is to better align with what I'm putting in the SDK repo. Hopefully I can eventually move this upstream to some of our shared test infra.
It does make it a little bit more awkward for VB, but not unusable.
Microsoft Reviewers: Open in CodeFlow