Fix SVE long narrowing for shifts #123666
Open
+20
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
area-CodeGen-coreclr
dotnet-policy-service
bot
added
the
community-contribution
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes an issue with SVE (Scalable Vector Extension) long narrowing operations for shift instructions by renaming and correcting the behavior of a SIMD narrowing function.
Changes:
- Renamed
NarrowSimdLongtoNarrowAndDuplicateSimdLongto accurately reflect its behavior of narrowing and duplicating elements - Fixed the element count calculation to use
sizeof(TBase)instead ofsizeof(uint64_t), which corrects the narrowing operation for shifts - Updated all call sites to use the renamed function
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/coreclr/jit/simd.h | Renamed function and fixed count calculation; added comprehensive XML documentation |
| src/coreclr/jit/valuenum.cpp | Updated function call to use renamed function |
| src/coreclr/jit/gentree.cpp | Updated function call to use renamed function |
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @dotnet/jit-contrib |
Contributor
Author
|
@dotnet/arm64-contrib |
EgorBo
approved these changes
Jan 27, 2026
This was referenced Jan 28, 2026
Open
Contributor
Author
|
SPMI issues look unrelated to this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #123496