Polyfill span.Contains(T) #123656
Draft
Polyfill span.Contains(T) #123656
+120
−151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Tagging subscribers to this area: @dotnet/area-meta |
This was referenced Jan 27, 2026
Open
stephentoub
reviewed
Jan 27, 2026
src/libraries/System.CodeDom/src/Microsoft/CSharp/CSharpCodeGenerator.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jan 27, 2026
| _minLength = minLength; | ||
| _maxLength = maxLength; | ||
| _invalidChars = invalidCharacters; | ||
| _invalidChars = SearchValues.Create(invalidCharacters ?? string.Empty); |
Member
There was a problem hiding this comment.
How frequently are these StringValidators created?
stephentoub
reviewed
Jan 27, 2026
...raries/System.Configuration.ConfigurationManager/src/System/Configuration/StringValidator.cs
Show resolved
Hide resolved
stephentoub
reviewed
Jan 27, 2026
...libraries/System.Text.Json/src/System/Text/Json/Writer/Utf8JsonWriter.WriteValues.Comment.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Jan 27, 2026
| JsonWriterHelper.ValidateValue(utf8Value); | ||
|
|
||
| if (utf8Value.IndexOf(SingleLineCommentDelimiterUtf8) != -1) | ||
| if (utf8Value.IndexOf(SingleLineCommentDelimiterUtf8) >= 0) |
Member
Author
There was a problem hiding this comment.
Looks like we don't have a Contains<T>(this ROS<T> span, ROS<T> value) helper yet, except for chars with the comparison type
stephentoub
approved these changes
Jan 27, 2026
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.