Fix CLI rename-symbol support for top-level statement #1721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….g. top-level statement string[] args)
…ymbolFinder.FindLocalSymbols
Author
|
@dotnet-policy-service agree |
josefpihrt
reviewed
Dec 9, 2025
|
|
||
| results.AddRange(methodSymbol.TypeParameters); | ||
| results.AddRange(methodSymbol.Parameters); | ||
| results.AddRange(methodSymbol.Parameters.Where(ms => !ms.IsImplicitlyDeclared)); |
Collaborator
There was a problem hiding this comment.
nitpick: rename lambda parameter to p
Collaborator
|
@andrtmschkw Please update changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Program.cs with top-level staments:
System.Console.WriteLine(args.Length); var y = 99; class X {} interface I {}rename-symbol fails in because ISymbol for args is ImplicitlyDeclared=true and the Locations are empty but it is accesses without a bounds check.
System.IndexOutOfRangeException: Index was outside the bounds of the array. at Roslynator.Rename.SymbolRenameState.<>c__DisplayClass30_0.<AnalyzeProjectAsync>b__0(ISymbol symbol) in \src\Workspaces.Core\Rename\SymbolRenameState.cs:line 173Also LocalSymbolFinder.FindLocalSymbols does not support nodes of SyntaxKind.CompilationUnit (top-level statement) and the assertion fails.