Improve error recovery in top level statements #81604
Draft
+607
−127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
Dec 9, 2025
| var state = _termState; | ||
| _termState |= TerminatorState.IsPossibleStatementStartOrStop; | ||
| var topLevelStatement = ParseLocalDeclarationStatement(attributes); | ||
| _termState = state; |
Member
Author
There was a problem hiding this comment.
note: this also follows the logic in tryParseStatement below. This was just missed when the global code parser decides to specifically only parse out a localdecl statement, not any arbitrary statement.
CyrusNajmabadi
commented
Dec 9, 2025
| void C() { } | ||
| } | ||
| } | ||
| """; |
Member
Author
There was a problem hiding this comment.
this didn't change at all. just adding an explicit test showing the behavior when we are not at the top level.
CyrusNajmabadi
commented
Dec 9, 2025
| } | ||
| N(SyntaxKind.GlobalStatement); | ||
| { | ||
| N(SyntaxKind.LocalFunctionStatement); |
Member
Author
There was a problem hiding this comment.
this changed. we would previously not get this, and instead end up with most of what followed becoming skipped tokens on the 'C'.
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #72077