Fix Float32HFFTN test to call hfftn instead of hfft2#1539
Draft
Copilot wants to merge 2 commits intofix-hfft-real-input-testfrom
Draft
Fix Float32HFFTN test to call hfftn instead of hfft2#1539Copilot wants to merge 2 commits intofix-hfft-real-input-testfrom
Copilot wants to merge 2 commits intofix-hfft-real-input-testfrom
Conversation
Co-authored-by: alinpahontu2912 <56953855+alinpahontu2912@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix HFFT tests to use complex input tensors
Fix Float32HFFTN test to call hfftn instead of hfft2
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Float32HFFTNtest method was incorrectly testingfft.hfft2instead offft.hfftn, despite its name and the existence of a separateFloat64HFFTNtest that correctly testshfftn.Changes:
[TestOf]attribute fromfft.hfft2tofft.hfftnfft.hfft2()tofft.hfftn()fft.ihfft2()tofft.ihfftn()The test now correctly validates the n-dimensional Hermitian FFT function matching its method name.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.