CODEGEN-793 - Treat line endings same when using --check flag#10340
Draft
CODEGEN-793 - Treat line endings same when using --check flag#10340
Conversation
🦋 Changeset detectedLatest commit: 2cacfbb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
eddeee888
changed the title
Contributor
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-codegen/cli |
5.0.6-alpha-20250414132312-2cacfbb956012f0df94008f4636b6c03ccca15b4 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-operations |
4.6.1-alpha-20250414132312-2cacfbb956012f0df94008f4636b6c03ccca15b4 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-resolvers |
4.5.1-alpha-20250414132312-2cacfbb956012f0df94008f4636b6c03ccca15b4 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/client-preset |
4.8.1-alpha-20250414132312-2cacfbb956012f0df94008f4636b6c03ccca15b4 |
npm ↗︎ unpkg ↗︎ |
Contributor
💻 Website PreviewThe latest changes are available as preview in: https://pr-10340.graphql-code-generator.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We want seamless experience for users of all OS.
--checkflag currently doesn't work for Windows users when something saves the generated file.This PR treats line endings the same by converting them both back to Linux style when comparing for hash values.
Related #10309
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration