Skip to content

modernize some code#13588

Merged
ndeloof merged 1 commit intodocker:mainfrom
thaJeztah:modernize
Feb 12, 2026
Merged

modernize some code#13588
ndeloof merged 1 commit intodocker:mainfrom
thaJeztah:modernize

Conversation

@thaJeztah
Copy link
Member

Results of running the modernize command, with some minor changes afterwards (removing the contains and hasStatus helper functions);

go install golang.org/x/tools/go/analysis/passes/modernize/cmd/modernize@latest
modernize -fix ./...

What I did

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

Results of running the modernize command, with some minor changes
afterwards (removing the `contains` and `hasStatus` helper functions);

    go install golang.org/x/tools/go/analysis/passes/modernize/cmd/modernize@latest
    modernize -fix ./...

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah requested a review from a team as a code owner February 11, 2026 22:13
@thaJeztah thaJeztah requested review from glours and ndeloof February 11, 2026 22:13
@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 56.25000% with 7 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cmd/formatter/shortcut.go 0.00% 2 Missing ⚠️
internal/tracing/mux.go 0.00% 2 Missing ⚠️
cmd/compose/config.go 0.00% 1 Missing ⚠️
cmd/display/tty.go 83.33% 1 Missing ⚠️
pkg/compose/push.go 0.00% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@ndeloof ndeloof merged commit f9828df into docker:main Feb 12, 2026
40 checks passed
@thaJeztah thaJeztah deleted the modernize branch February 12, 2026 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants