Skip to content

pkg/compose: un-export consts#13584

Merged
glours merged 1 commit intodocker:mainfrom
thaJeztah:unexport_consts
Feb 11, 2026
Merged

pkg/compose: un-export consts#13584
glours merged 1 commit intodocker:mainfrom
thaJeztah:unexport_consts

Conversation

@thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Feb 11, 2026

pkg/compose: un-export consts

These consts were added in b760afa, but are only user internal in the package.

Given that the list of consts may change over time, it's probably best to keep them internal and not part of the module's API.

What I did

Related issue

(not mandatory) A picture of a cute animal, if possible in relation to what you did

@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

❌ Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
pkg/compose/build_bake.go 0.00% 1 Missing and 1 partial ⚠️
pkg/compose/create.go 33.33% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

These consts were added in b760afa,
but are only user internal in the package. Given that the list of
consts may change over time, it's probably best to keep them internal
and not part of the module's API.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah marked this pull request as ready for review February 11, 2026 15:06
@thaJeztah thaJeztah requested a review from a team as a code owner February 11, 2026 15:06
@thaJeztah thaJeztah requested review from glours and ndeloof February 11, 2026 15:06
@glours glours merged commit da691c7 into docker:main Feb 11, 2026
40 checks passed
@thaJeztah thaJeztah deleted the unexport_consts branch February 11, 2026 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants