PRIVATE_PORT optional for docker compose port#13577
Open
maxproske wants to merge 1 commit intodocker:mainfrom
Open
PRIVATE_PORT optional for docker compose port#13577maxproske wants to merge 1 commit intodocker:mainfrom
docker compose port#13577maxproske wants to merge 1 commit intodocker:mainfrom
Conversation
maxproske
force-pushed
the
11859-optional-port-arg
branch
2 times, most recently
from
108cf9e to
e8b4d94
Compare
Signed-off-by: Max Proske <max@mproske.com>
maxproske
force-pushed
the
11859-optional-port-arg
branch
from
e8b4d94 to
c350344
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Closes #11859, and continues #11874 which was approved but went stale.
AI Disclaimer: Claude Code helped sharpen after I incorporated all requested changes from the stale PR.
What I did
Align
docker compose portcloser withdocker port. When no port given, list all mappings.Future improvement: allow inline protocol like docker port does (eg. 80/udp)?