bake: support host-suffixed git auth env vars#3648
Open
crazy-max wants to merge 1 commit intodocker:masterfrom
Open
bake: support host-suffixed git auth env vars#3648crazy-max wants to merge 1 commit intodocker:masterfrom
crazy-max wants to merge 1 commit intodocker:masterfrom
Conversation
crazy-max
force-pushed
the
bake-auth-token-domain
branch
from
ac8f506 to
8573243
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
bake-auth-token-domain
branch
from
8573243 to
22217e5
Compare
Member
Author
3 tasks
tonistiigi
reviewed
Feb 10, 2026
Member
tonistiigi
left a comment
tonistiigi
left a comment
There was a problem hiding this comment.
I don't think users should need to set the host in the env variable. We can just get the host from the remote URL and connect these automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/moby/buildkit/blob/bb7bb2048e724af22a14598043964476cb45c2cc/source/git/source.go#L364-L369