feat: set checked marker orange, delete unnecessary code in app.js fr… #396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rizomaa
reviewed
Jul 14, 2020
|
|
||
| dispatch(Actions.setCurrentEntry(id, null)); | ||
| return dispatch(Actions.showLeftPanel()); | ||
| }} |
Collaborator
There was a problem hiding this comment.
@chizhovm калі ласка вярніце код, гэты код і стварыце асобную картку, апішыце чаму вырашылі, ягэ прыбраць.
Падказка.
Калі ласка кіруйцеся вынікамі нашай раўмовы. І заўвагай, што гэты код магчыма адказвае за функцыю пацверджання выхаду з рэжыма рэдагавання, але стаіць не у патрэбнм месцы.
Падказка 2.
Выкарыстоўвай асобныя галіны для кожнага ПР. Тадыя код не склейваецца у адну пачку.
Collaborator
|
@chizhovm дадаў свае каментары. чакаю абноўленага ПР |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…om onMarkerClick()