Skip to content

Conversation

@jasonz-dfinity
Copy link
Contributor

Why

For most NNS Functions, we call the canister_metadata on the target canister in order to translate the payload into meaningful data. However, the ic_00 (management canister) is not a real canister, and therefore we cannot translate the payload of the UninstallCode function.

What

When the target canister is ic_00, use a hard-coded string instead of calling canister_metadata

@jasonz-dfinity jasonz-dfinity requested a review from a team as a code owner December 18, 2025 22:05
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):

  1. Update unreleased_changelog.md (if there are behavior changes, even if they are
    non-breaking).

  2. Are there BREAKING changes?

  3. Is a data migration needed?

  4. Security review?

How to Satisfy This Automatic Review

  1. Go to the bottom of the pull request page.

  2. Look for where it says this bot is requesting changes.

  3. Click the three dots to the right.

  4. Select "Dismiss review".

  5. In the text entry box, respond to each of the numbered items in the previous
    section, declare one of the following:

  • Done.

  • $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
    canister behavior changes.", or for item 2, "Existing APIs
    behave as before.".

Brief Guide to "Externally Visible" Changes

"Externally visible behavior change" is very often due to some NEW canister API.

Changes to EXISTING APIs are more likely to be "breaking".

If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.

If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.

Reference(s)

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

@jasonz-dfinity jasonz-dfinity dismissed github-actions[bot]’s stale review January 6, 2026 00:22

No canister behavior changes (behind feature flag)

@jasonz-dfinity jasonz-dfinity added this pull request to the merge queue Jan 6, 2026
Merged via the queue into master with commit 3b0368a Jan 6, 2026
38 checks passed
@jasonz-dfinity jasonz-dfinity deleted the jason/NNS1-4282-1 branch January 6, 2026 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants