New package: libwebsockets #213
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WinterMute
requested changes
Apr 28, 2021
| -DLWS_PLAT_NX=ON \ | ||
| -DLWS_WITH_UDP=OFF \ | ||
| -DLWS_WITH_FILE_OPS=OFF \ | ||
| -DCMAKE_BUILD_TYPE=DEBUG \ |
Member
There was a problem hiding this comment.
We want -DCMAKE_BUILD_TYPE=RELEASE here I think.
| +#include <arpa/inet.h> | ||
| +#include <fcntl.h> | ||
| +#include <switch/kernel/mutex.h> | ||
| +#include <switch/services/bsd.h> |
Member
There was a problem hiding this comment.
don't use this bsd header. We translate between newlib fds & horizon fds internally. Use standard <sys/socket.h>
| +#define compatible_close(x) close(x) | ||
| +#define lws_plat_socket_offset() 0 | ||
| +#define wsi_from_fd(A,B) A->lws_lookup[B - lws_plat_socket_offset()] | ||
| +#define shutdown(sockfd, how) bsdShutdown(sockfd, how) |
Member
There was a problem hiding this comment.
shutdown is found in <sys/socket.h> don't use the bsd functions directly.
Author
|
Thanks for the review @WinterMute! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for libwebsockets
the port is pretty simple, mostly the same as the
freertosplatform used by esp32