Add diagnostic logging to updateUID for CI investigation

.github/workflows/dev-containers.yml

@@ -69,6 +69,19 @@ jobs:
         node-version: '18.x'
         registry-url: 'https://npm.pkg.github.com'
         scope: '@microsoft'
+    - name: Docker Version (before update)
+      run: docker version
+    - name: Update Docker
+      run: |
+        # Add Docker's official APT repository
+        sudo install -m 0755 -d /etc/apt/keyrings
+        sudo curl -fsSL https://download.docker.com/linux/ubuntu/gpg -o /etc/apt/keyrings/docker.asc
+        sudo chmod a+r /etc/apt/keyrings/docker.asc
+        echo "deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/docker.asc] https://download.docker.com/linux/ubuntu $(. /etc/os-release && echo "$VERSION_CODENAME") stable" | sudo tee /etc/apt/sources.list.d/docker.list > /dev/null
+        sudo apt-get update
+        sudo apt-get install -y docker-ce docker-ce-cli containerd.io docker-buildx-plugin
+    - name: Docker Version (after update)
+      run: docker version
     - name: Tools Info
       run: |
         docker info
@@ -84,7 +97,7 @@ jobs:
     - name: Package
       run: yarn package
     - name: Run Tests
-      run: yarn test-matrix --forbid-only ${{ matrix.mocha-args }}
+      run: yarn test-matrix ${{ matrix.mocha-args }}
       env:
         CI: true
 

.github/workflows/docker-platform-bug.yml

@@ -0,0 +1,87 @@
+name: Docker Platform Bug Repro
+
+on:
+  push:
+    branches:
+      - 'chrmarti/**'
+
+jobs:
+  repro:
+    name: Platform Bug Repro
+    runs-on: ubuntu-latest
+    steps:
+    - name: Update Docker
+      run: |
+        sudo install -m 0755 -d /etc/apt/keyrings
+        sudo curl -fsSL https://download.docker.com/linux/ubuntu/gpg -o /etc/apt/keyrings/docker.asc
+        sudo chmod a+r /etc/apt/keyrings/docker.asc
+        echo "deb [arch=$(dpkg --print-architecture) signed-by=/etc/apt/keyrings/docker.asc] https://download.docker.com/linux/ubuntu $(. /etc/os-release && echo "$VERSION_CODENAME") stable" | sudo tee /etc/apt/sources.list.d/docker.list > /dev/null
+        sudo apt-get update
+        sudo apt-get install -y docker-ce docker-ce-cli containerd.io docker-buildx-plugin
+    - name: Docker Version
+      run: docker version
+    - name: Docker Info
+      run: docker info
+    - name: Setup QEMU
+      run: docker run --privileged --rm tonistiigi/binfmt --install all
+    - name: Build with platform in Dockerfile only
+      run: |
+        dir=$(mktemp -d)
+        echo 'FROM --platform=linux/arm64 debian:latest' > "$dir/Dockerfile"
+        docker buildx build --load -t test-arm64-in-dockerfile "$dir"
+    - name: Inspect manifest list (Dockerfile platform)
+      run: |
+        docker image inspect test-arm64-in-dockerfile --format '{{.Architecture}}'
+        digest=$(docker image inspect test-arm64-in-dockerfile --format '{{.Id}}')
+        docker save test-arm64-in-dockerfile | tar -xO blobs/sha256/${digest#sha256:} | python3 -c "
+        import sys, json
+        data = json.load(sys.stdin)
+        if 'manifests' in data:
+            print('Manifest list found:')
+            for m in data['manifests']:
+                p = m.get('platform', {})
+                t = m.get('annotations', {}).get('vnd.docker.reference.type', 'image')
+                print(f'  type={t} arch={p.get(\"architecture\")} os={p.get(\"os\")} variant={p.get(\"variant\", \"\")}')
+        else:
+            print('No manifest list (single manifest)')
+        "
+    - name: Build using that image as base with --platform linux/arm64
+      run: |
+        dir=$(mktemp -d)
+        echo 'FROM test-arm64-in-dockerfile' > "$dir/Dockerfile"
+        echo "Expecting this to fail due to manifest list platform mismatch..."
+        if docker build --platform linux/arm64 -t test-arm64-rebuild "$dir" 2>&1; then
+          echo "BUILD SUCCEEDED (bug may be fixed)"
+        else
+          echo "BUILD FAILED (bug confirmed)"
+        fi
+    - name: Build with --platform on CLI
+      run: |
+        dir=$(mktemp -d)
+        echo 'FROM debian:latest' > "$dir/Dockerfile"
+        docker buildx build --load --platform linux/arm64 -t test-arm64-on-cli "$dir"
+    - name: Inspect manifest list (CLI platform)
+      run: |
+        docker image inspect test-arm64-on-cli --format '{{.Architecture}}'
+        digest=$(docker image inspect test-arm64-on-cli --format '{{.Id}}')
+        docker save test-arm64-on-cli | tar -xO blobs/sha256/${digest#sha256:} | python3 -c "
+        import sys, json
+        data = json.load(sys.stdin)
+        if 'manifests' in data:
+            print('Manifest list found:')
+            for m in data['manifests']:
+                p = m.get('platform', {})
+                t = m.get('annotations', {}).get('vnd.docker.reference.type', 'image')
+                print(f'  type={t} arch={p.get(\"architecture\")} os={p.get(\"os\")} variant={p.get(\"variant\", \"\")}')
+        else:
+            print('No manifest list (single manifest)')
+        "
+    - name: Build using CLI-platform image with --platform linux/arm64
+      run: |
+        dir=$(mktemp -d)
+        echo 'FROM test-arm64-on-cli' > "$dir/Dockerfile"
+        if docker build --platform linux/arm64 -t test-arm64-on-cli-rebuild "$dir" 2>&1; then
+          echo "BUILD SUCCEEDED (expected)"
+        else
+          echo "BUILD FAILED (unexpected)"
+        fi

src/spec-node/containerFeatures.ts

@@ -7,7 +7,7 @@ import * as path from 'path';
 
 import { DevContainerConfig } from '../spec-configuration/configuration';
 import { dockerCLI, dockerPtyCLI, ImageDetails, toExecParameters, toPtyExecParameters } from '../spec-shutdown/dockerUtils';
-import { LogLevel, makeLog } from '../spec-utils/log';
+import { LogLevel, makeLog, nullLog } from '../spec-utils/log';
 import { FeaturesConfig, getContainerFeaturesBaseDockerFile, getFeatureInstallWrapperScript, getFeatureLayers, getFeatureMainValue, getFeatureValueObject, generateFeaturesConfig, Feature, generateContainerEnvs } from '../spec-configuration/containerFeaturesConfiguration';
 import { readLocalFile } from '../spec-utils/pfs';
 import { includeAllConfiguredFeatures } from '../spec-utils/product';
@@ -420,12 +420,13 @@ function getFeatureEnvVariables(f: Feature) {
 
 export async function getRemoteUserUIDUpdateDetails(params: DockerResolverParameters, mergedConfig: MergedDevContainerConfig, imageName: string, imageDetails: () => Promise<ImageDetails>, runArgsUser: string | undefined) {
 	const { common } = params;
-	const { cliHost } = common;
+	const { cliHost, output } = common;
 	const { updateRemoteUserUID } = mergedConfig;
 	if (params.updateRemoteUserUIDDefault === 'never' || !(typeof updateRemoteUserUID === 'boolean' ? updateRemoteUserUID : params.updateRemoteUserUIDDefault === 'on') || !(cliHost.platform === 'linux' || params.updateRemoteUserUIDOnMacOS && cliHost.platform === 'darwin')) {
 		return null;
 	}
 	const details = await imageDetails();
+	output.write(`updateUID: image=${imageName} Os=${details.Os} Architecture=${details.Architecture} Variant=${details.Variant || '(none)'}`, LogLevel.Info);
 	const imageUser = details.Config.User || 'root';
 	const remoteUser = mergedConfig.remoteUser || runArgsUser || imageUser;
 	if (remoteUser === 'root' || /^\d+$/.test(remoteUser)) {
@@ -434,11 +435,13 @@ export async function getRemoteUserUIDUpdateDetails(params: DockerResolverParame
 	const folderImageName = getFolderImageName(common);
 	const fixedImageName = `${imageName.startsWith(folderImageName) ? imageName : folderImageName}-uid`;
 
+	const platform = [details.Os, details.Architecture, details.Variant].filter(Boolean).join('/');
+	output.write(`updateUID: remoteUser=${remoteUser} imageUser=${imageUser} platform=${platform}`, LogLevel.Info);
 	return {
 		imageName: fixedImageName,
 		remoteUser,
 		imageUser,
-		platform: [details.Os, details.Architecture, details.Variant].filter(Boolean).join('/')
+		platform,
 	};
 }
 
@@ -451,6 +454,39 @@ export async function updateRemoteUserUID(params: DockerResolverParameters, merg
 		return imageName;
 	}
 	const { imageName: fixedImageName, remoteUser, imageUser, platform } = updateDetails;
+	const { output } = common;
+
+	try {
+		const infoResult = await dockerCLI(params, 'info', '--format', '{{.Driver}} / containerd: {{.DriverStatus}}');
+		output.write(`updateUID: docker info: ${infoResult.stdout.toString().trim()}`, LogLevel.Info);
+	} catch (err) {
+		output.write(`updateUID: docker info failed: ${err}`, LogLevel.Warning);
+	}
+	try {
+		const inspectResult = await dockerCLI(params, 'inspect', '--type', 'image', imageName);
+		const inspectJson = inspectResult.stdout.toString().trim();
+		output.write(`updateUID: docker inspect ${imageName}: ${inspectJson}`, LogLevel.Info);
+		// Extract the OCI index from docker save to see manifest list platform annotations
+		try {
+			const parsed = JSON.parse(inspectJson);
+			const digest = parsed[0]?.Descriptor?.digest;
+			if (digest) {
+				const hash = digest.replace('sha256:', '').replace(':', '/');
+				// docker save outputs OCI layout; extract the manifest list blob by digest
+				const saveResult = await runCommandNoPty({
+					exec: common.cliHost.exec,
+					cmd: '/bin/sh',
+					args: ['-c', `docker save ${imageName} | tar -xO blobs/sha256/${hash} 2>/dev/null || docker save ${imageName} | tar -xO index.json 2>/dev/null`],
+					output: nullLog
+				});
+				output.write(`updateUID: manifest list for ${imageName}: ${saveResult.stdout.toString().trim()}`, LogLevel.Info);
+			}
+		} catch (blobErr) {
+			output.write(`updateUID: reading manifest list failed: ${blobErr instanceof Error ? blobErr.message : JSON.stringify(blobErr)}`, LogLevel.Warning);
+		}
+	} catch (err) {
+		output.write(`updateUID: docker inspect failed: ${err}`, LogLevel.Warning);
+	}
 
 	const dockerfileName = 'updateUID.Dockerfile';
 	const srcDockerfile = path.join(common.extensionPath, 'scripts', dockerfileName);
@@ -474,6 +510,7 @@ export async function updateRemoteUserUID(params: DockerResolverParameters, merg
 		'--build-arg', `IMAGE_USER=${imageUser}`,
 		emptyFolder,
 	];
+	output.write(`updateUID: docker ${args.join(' ')}`, LogLevel.Info);
 	if (params.isTTY) {
 		await dockerPtyCLI(params, ...args);
 	} else {

src/test/testUtils.ts

@@ -89,7 +89,7 @@ export async function shellPtyExec(command: string, options: { stdin?: string }
 }
 
 export async function devContainerUp(cli: string, workspaceFolder: string, options?: { cwd?: string; useBuildKit?: boolean; userDataFolder?: string; logLevel?: string; extraArgs?: string; prefix?: string; env?: NodeJS.ProcessEnv }): Promise<UpResult> {
-    const buildkitOption = (options?.useBuildKit ?? false) ? '' : ' --buildkit=never';
+    const buildkitOption = (options?.useBuildKit ?? true) ? '' : ' --buildkit=never';
     const userDataFolderOption = (options?.userDataFolder ?? false) ? ` --user-data-folder=${options?.userDataFolder}` : '';
     const logLevelOption = (options?.logLevel ?? false) ? ` --log-level ${options?.logLevel}` : '';
     const extraArgs = (options?.extraArgs ?? false) ? ` ${options?.extraArgs}` : '';

src/test/updateUID.test.ts

@@ -9,7 +9,7 @@ import { devContainerDown, devContainerUp, shellExec } from './testUtils';
 
 const pkg = require('../../package.json');
 
-(process.platform === 'linux' ? describe : describe.skip)('Dev Containers CLI', function () {
+(process.platform === 'linux' ? describe.only : describe.skip)('Dev Containers CLI', function () {
 	this.timeout('120s');
 
 	const tmp = path.relative(process.cwd(), path.join(__dirname, 'tmp'));