feat: descopers & management key CRUD #613
Open
+855
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds support for managing "descopers" (internal users/administrators) in the management API. It introduces CRUD operations for creating, reading, updating, deleting, and listing descopers with role-based access control (RBAC) support.
Key changes:
- Added type definitions for descoper entities, attributes, roles, and RBAC configuration
- Implemented five management operations: create, load, update, delete, and loadAll
- Comprehensive test coverage for all descoper operations
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| lib/management/types.ts | Defines TypeScript types for descoper entities, RBAC, roles, and API request/response structures |
| lib/management/paths.ts | Adds API endpoint paths for descoper CRUD operations |
| lib/management/index.ts | Integrates descoper module into the main management API |
| lib/management/descoper.ts | Implements descoper management functions with HTTP client wrappers |
| lib/management/descoper.test.ts | Provides comprehensive unit tests for all descoper operations |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
2 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 9 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Part-of: https://github.com/descope/etc/issues/12606
Depends-on: descope/descope-js#1292
Cover new Descoper methods..
Must