Skip to content

Conversation

@ianbeu
Copy link
Contributor

@ianbeu ianbeu commented Dec 5, 2025

  • Bug fix #…?

  • New feature?

  • BC breaks?

  • Tests added?

  • Docs added?

    Please, regenerate docs by running next command:
    $ php bin/docgen
    

Explanation: Some writable directories already have ACLs on the root, which makes the existing skip logic skip nested paths when running recursively. The new writable_acl_force option lets users reapply ACLs regardless of the root check so nested directories get the intended permissions, fixing deployments where ACL inheritance was previously missed. That said, this option is mainly intended to be used manually whenever the ACLs seem to be wrong and using sudo is not an option on the system.

Copilot AI review requested due to automatic review settings December 5, 2025 08:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR introduces a new writable_acl_force configuration option to allow forcing ACL (Access Control List) resets on writable directories, even when they already have ACLs configured. This addresses deployment scenarios where directory ACLs on the root level prevent nested paths from receiving proper permissions during recursive ACL operations.

Key changes:

  • Added writable_acl_force boolean configuration (defaults to false) to force ACL reapplication
  • Updated ACL-checking logic to respect the new force flag in non-sudo scenarios
  • Generated documentation for the new configuration option

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
recipe/deploy/writable.php Adds writable_acl_force configuration and updates ACL logic to check this flag before skipping directories that already have ACLs
docs/recipe/deploy/writable.md Auto-generated documentation for the new writable_acl_force option with source references and default value
.gitignore Adds .idea/ directory (JetBrains IDE configuration) to ignored files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@antonmedv antonmedv merged commit f8a4af5 into deployphp:master Dec 8, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants