fix: detect macOS ACL support using uname instead of chmod output #4137
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When
deploy:writableruns inaclmode, the code detects macOS ACL support by running:This outputs an error message to the deployment logs:
While the command succeeds (due to
; true), the error message clutters deployment output.Solution
Since
chmod +ais macOS-specific (Linux and FreeBSD usesetfacl/getfaclinstead), we can directly check the OS:This is:
chmod +aReferences
chmod +a/-a/=afor ACL managementsetfacl/getfacl(POSIX ACLs)setfacl/getfacldespite being BSD-based