Improve handling of ssh-agent process #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22
Currently I have the following added to all of my workflow files using the deployerphp action for our self hosted runners:
This works fine, however recently we had started having multiple runner instances on each of our runner servers and conflicts began to arise with my solution due to the usage of
killallWhile I could have improved killing off the ssh-agent, I've decided to take a crack at implement a way of handling the
ssh-agentprocess a little more nicely within the action iteself and have ended up with this.There is probably a slightly better way of doing this via a proper setting, however I was aiming for backwards compatibility where possible.
What this PR does:
Why make these changes: