Skip to content

Conversation

@tomas-zijdemans
Copy link
Contributor

Ref: #6982 and #6984

@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.20%. Comparing base (e80e6bb) to head (adcc8e6).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6989      +/-   ##
==========================================
- Coverage   94.26%   94.20%   -0.06%     
==========================================
  Files         602      613      +11     
  Lines       43662    47710    +4048     
  Branches     7063     8299    +1236     
==========================================
+ Hits        41159    44947    +3788     
- Misses       2447     2696     +249     
- Partials       56       67      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lionel-rowe
Copy link
Contributor

This might be better to word more generically, as there are other objects that could suffer from this problem, and also (as of current logic, pending decision on proposed logic of #6982) only potential false negatives are a known limitation, whereas false positives would be bugs.

I'd word it maybe something like this:

This function is based on value equality, but for some cases (such as data that can only be read asynchronously or function properties) value equality is not possible to determine. In such cases, reference equality is used instead, which may cause false negatives for objects such as Blobs or Requests.

Non-enumerable symbol properties might be the specific implementation detail that makes this problem visible for Blob etc, but it's not the think that makes the problem intractable, so it's probably (?) not worth mentioning.

@tomas-zijdemans
Copy link
Contributor Author

That is better indeed. Updated now. Thanks @lionel-rowe!

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nicer and clearer! Thanks

@kt3k kt3k merged commit 49e9ea0 into denoland:main Feb 9, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants