Skip to content

refactor(yaml): add Scanner class#6958

Merged
kt3k merged 1 commit intodenoland:mainfrom
timreichen:yaml-add-scanner-class
Feb 10, 2026
Merged

refactor(yaml): add Scanner class#6958
kt3k merged 1 commit intodenoland:mainfrom
timreichen:yaml-add-scanner-class

Conversation

@timreichen
Copy link
Contributor

This PR moves scanner related code from LoaderState into a dedicated Scanner class.

@timreichen timreichen requested a review from kt3k as a code owner January 17, 2026 11:15
@github-actions github-actions bot added the yaml label Jan 17, 2026
@codecov
Copy link

codecov bot commented Jan 17, 2026

Codecov Report

❌ Patch coverage is 95.06726% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 94.08%. Comparing base (0aa59e2) to head (8562b37).
⚠️ Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
yaml/_loader_state.ts 95.06% 11 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6958   +/-   ##
=======================================
  Coverage   94.08%   94.08%           
=======================================
  Files         600      600           
  Lines       43540    43591   +51     
  Branches     6991     6993    +2     
=======================================
+ Hits        40965    41014   +49     
- Misses       2520     2522    +2     
  Partials       55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@kt3k kt3k merged commit d3d380a into denoland:main Feb 10, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants