feat: use @deno/cache-dir to resolve deno dir#359
Open
uncenter wants to merge 5 commits intodenoland:mainfrom
Open
feat: use @deno/cache-dir to resolve deno dir#359uncenter wants to merge 5 commits intodenoland:mainfrom
uncenter wants to merge 5 commits intodenoland:mainfrom
Conversation
Contributor
|
Hey, be great if you could also edit your comment to mention that this PR would also close #134. Thanks for getting the ball rolling on this one! 💖 |
Author
|
Would someone be able to take a look at this? 👀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An alternative to #358. Uses the TypeScript library of https://github.com/denoland/deno_cache_dir to resolve the cache directory the same as Deno core does. Closes #357 and closes #134 now that denoland/deno_cache_dir#73 was merged upstream.