Skip to content

Conversation

@denny
Copy link
Owner

@denny denny commented Jul 28, 2025

The code for this is currently very heavily based on the Page/Section/Template stack, so hopefully somewhat proven already.

The differences are mostly in how the deletion of products is handled (Stripe doesn't allow it), and hence some of the stuff around sections has to be different too.

@codecov
Copy link

codecov bot commented Aug 4, 2025

Codecov Report

❌ Patch coverage is 87.65432% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 99.35%. Comparing base (34f32e4) to head (cfe3d9d).

Files with missing lines Patch % Lines
.../app/controllers/shiny_shop/products_controller.rb 50.81% 30 Missing ⚠️
plugins/ShinyShop/app/models/shiny_shop/section.rb 77.27% 10 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main    #2075      +/-   ##
===========================================
- Coverage   100.00%   99.35%   -0.65%     
===========================================
  Files          418      427       +9     
  Lines         5864     6175     +311     
===========================================
+ Hits          5864     6135     +271     
- Misses           0       40      +40     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@denny denny added ruby Involves Ruby code work-in-progress WIP - do not merge major Big (or otherwise significant) pieces of work feature plugins Involves one or more of the non-core plugins labels Aug 6, 2025
Denny added 30 commits October 27, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature plugins Involves one or more of the non-core plugins major Big (or otherwise significant) pieces of work ruby Involves Ruby code work-in-progress WIP - do not merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants