-
Notifications
You must be signed in to change notification settings - Fork 13
Add templates and sections to shop #2075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
denny
wants to merge
102
commits into
main
Choose a base branch
from
feature/shop-product-descriptions
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2075 +/- ##
===========================================
- Coverage 100.00% 99.35% -0.65%
===========================================
Files 418 427 +9
Lines 5864 6175 +311
===========================================
+ Hits 5864 6135 +271
- Misses 0 40 +40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature plugins
Involves one or more of the non-core plugins
major
Big (or otherwise significant) pieces of work
ruby
Involves Ruby code
work-in-progress
WIP - do not merge
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code for this is currently very heavily based on the Page/Section/Template stack, so hopefully somewhat proven already.
The differences are mostly in how the deletion of products is handled (Stripe doesn't allow it), and hence some of the stuff around sections has to be different too.