Update unit_tests.sql to replace square brackets with double quotes#568
Open
danakee wants to merge 1 commit intodbt-msft:masterfrom
Open
Update unit_tests.sql to replace square brackets with double quotes#568danakee wants to merge 1 commit intodbt-msft:masterfrom
danakee wants to merge 1 commit intodbt-msft:masterfrom
Conversation
Replace square brackets with double quotes and insert "." between schema and view in setting of test_view and expected_view. Result was [dbo.testview_123] will now be "dbo"."testview_123" Result was [dbo.expectedview_123] will now be "dbo"."expectedview_123"
Collaborator
|
Happy to merge this but you'll need to create a unit test to capture the breaking behaviour first before it can be merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace square brackets with double quotes and insert "." between schema and view in setting of test_view and expected_view.
Result was [dbo.testview_123] will now be "dbo"."testview_123" Result was [dbo.expectedview_123] will now be "dbo"."expectedview_123"