add requestAnimationFrame#47
Open
jeroensak wants to merge 1 commit intodbramwell:masterfrom
jeroensak:jeroensak-requestanimationframe
Open
add requestAnimationFrame#47jeroensak wants to merge 1 commit intodbramwell:masterfrom jeroensak:jeroensak-requestanimationframe
jeroensak wants to merge 1 commit intodbramwell:masterfrom
jeroensak:jeroensak-requestanimationframe
Conversation
add requestAnimationFrame to optimize smooth animations. Also fallback for browsers without support.
Owner
|
Hi, Thanks for the pull request. I might be missing something, as I hadn't heard of requestAnimationFrame before now, but I'm not sure that this is how it's supposed to be used. From the documentation I think it's supposed to be used to actually change the style of an element, similar to this example. React-animate-on-scroll uses CSS animations, so it doesn't work in the same way. I'm very possibly missing something though. Could you explain how the 'requestAnimationFrame' function helps? Also, the tests seem to have broken, these would need to be fixed before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add requestAnimationFrame to optimize smooth animations. Also fallback for browsers without support.