when opening a file for execution, use the same encoding as in the da…#961
Draft
when opening a file for execution, use the same encoding as in the da…#961
Conversation
Member
Author
|
WIP: connection charsets are not the same thing as file encodings, we need to maintain a mapping between them. |
Contributor
Right! They are really different things. A user can even have a file they want to read which is in a different encoding than the connection type. Therefore I think we should close this PR. We could have |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tabase connector
Description
Fixes #953
Checklist
changelog.md.AUTHORSfile (or it's already there).