Don't emit keyring-saved message unless needed#1510
Merged
rolandwalker merged 1 commit intomainfrom Feb 5, 2026
Merged
Conversation
scottnemes
approved these changes
Feb 5, 2026
Contributor
scottnemes
left a comment
scottnemes
left a comment
There was a problem hiding this comment.
Works as-is.
Question for this or a future PR though:
Should we be waiting until after a successful connection to save the password to the keyring? As-is it will save and then go on to fail the connection if the password is wrong. I don't normally use a keyring so not sure what behavior the user would expect, but seems like it'd be preferable to only save if the password works.
Incidentally update message wordings to match CLI option: "keyring" rather than "keychain".
rolandwalker
force-pushed
the
RW/avoid-keyring-saved-message
branch
from
b7068cc to
190788c
Compare
Contributor
Author
|
Great point for future work: save the password only on a successful connection. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Don't emit keyring-saved message unless needed
Incidentally update message wordings to match CLI option: "keyring" rather than "keychain".
Checklist
changelog.mdfile.AUTHORSfile (or it's already there).