Skip to content

Conversation

@OscarLlamas6
Copy link
Contributor

Add IdentityProvider, IdentityProviderList, and IdentityProviderStatus types to the identity.miloapis.com/v1alpha1 API group. These types enable read-only exposure of user identity provider links through aggregated API servers.

The IdentityProvider resource includes:

  • Provider ID and name (e.g., GitHub, Google)
  • Associated IdP username
  • User UID for ownership tracking

Generated deepcopy and OpenAPI definitions are included.

Add IdentityProvider, IdentityProviderList, and IdentityProviderStatus
types to the identity.miloapis.com/v1alpha1 API group. These types
enable read-only exposure of user identity provider links through
aggregated API servers.

The IdentityProvider resource includes:
- Provider ID and name (e.g., GitHub, Google)
- Associated IdP username
- User UID for ownership tracking

Generated deepcopy and OpenAPI definitions are included.
@OscarLlamas6 OscarLlamas6 self-assigned this Dec 24, 2025
@joggrbot
Copy link
Contributor

joggrbot bot commented Dec 24, 2025

📝 Documentation Analysis

All docs are up to date! 🎉


✅ Latest commit analyzed: 379db53 | Powered by Joggr

OscarLlamas6 pushed a commit to datum-cloud/auth-provider-zitadel that referenced this pull request Dec 24, 2025
Implement a new read-only API endpoint at identity.miloapis.com/v1alpha1
that exposes identity provider links for authenticated users. This endpoint
allows UI clients to display which external identity providers (GitHub,
Google, etc.) are linked to a user's account along with their IdP usernames.

Changes include:
- Add ListIDPLinks method to Zitadel API interface
- Implement ListIDPLinks in SDK client using UserServiceV2
- Create REST storage for identityproviders resource
- Register identityproviders endpoint in API server
- Update API server title to "Milo Identity API"

The endpoint is read-only, self-scoping (users only see their own
providers), and does not expose sensitive credentials.

Depends on: datum-cloud/milo#464
@OscarLlamas6
Copy link
Contributor Author

Needed for datum-cloud/auth-provider-zitadel#59

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add some documentation types to explain what they are and how they're supposed to be used.

At first glance this appears to be for a user's identities? If so the term IdentityProvider is a little confusing because it sounds like a type that represents the actual identity provider (e.g. Google, GitHub, etc) and not the user's identity within that provider. Maybe, UserIdentity would be more appropriate for a user scoped identity resource?

Copy link
Contributor

@JoseSzycho JoseSzycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should update the iam-user-self-manage role and include the corresponding permissions.

https://github.com/datum-cloud/milo/blob/feat/identity-provider-api-types/config/roles/iam-user-self-manage.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants