-
Notifications
You must be signed in to change notification settings - Fork 2
chore: add IdentityProvider API types for v1alpha1 #464
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add IdentityProvider, IdentityProviderList, and IdentityProviderStatus types to the identity.miloapis.com/v1alpha1 API group. These types enable read-only exposure of user identity provider links through aggregated API servers. The IdentityProvider resource includes: - Provider ID and name (e.g., GitHub, Google) - Associated IdP username - User UID for ownership tracking Generated deepcopy and OpenAPI definitions are included.
Implement a new read-only API endpoint at identity.miloapis.com/v1alpha1 that exposes identity provider links for authenticated users. This endpoint allows UI clients to display which external identity providers (GitHub, Google, etc.) are linked to a user's account along with their IdP usernames. Changes include: - Add ListIDPLinks method to Zitadel API interface - Implement ListIDPLinks in SDK client using UserServiceV2 - Create REST storage for identityproviders resource - Register identityproviders endpoint in API server - Update API server title to "Milo Identity API" The endpoint is read-only, self-scoping (users only see their own providers), and does not expose sensitive credentials. Depends on: datum-cloud/milo#464
|
Needed for datum-cloud/auth-provider-zitadel#59 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add some documentation types to explain what they are and how they're supposed to be used.
At first glance this appears to be for a user's identities? If so the term IdentityProvider is a little confusing because it sounds like a type that represents the actual identity provider (e.g. Google, GitHub, etc) and not the user's identity within that provider. Maybe, UserIdentity would be more appropriate for a user scoped identity resource?
JoseSzycho
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should update the iam-user-self-manage role and include the corresponding permissions.
Add IdentityProvider, IdentityProviderList, and IdentityProviderStatus types to the identity.miloapis.com/v1alpha1 API group. These types enable read-only exposure of user identity provider links through aggregated API servers.
The IdentityProvider resource includes:
Generated deepcopy and OpenAPI definitions are included.