Enforce namespace consistency for ContactGroupMembership & MembershipRemoval when Contact targets resourcemanager API #348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds validation to ensure that the namespace of the ContactGroupMembership matches the namespace of the related Contact when the Contact's SubjectRef is associated with the resourcemanager.miloapis.com API group. Two new test cases have been introduced to verify this behavior, covering both matching and mismatched namespace scenarios.
…ntactGroupMembership Validation
Contributor
📝 Documentation AnalysisJoggr found 1 outdated docs in the pull request. AutofixJoggr opened 1 pull request(s) to fix the outdated docs. Outdated
|
Contributor
Author
|
@mustela FYI. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces improved namespace validation logic for both ContactGroupMembership and ContactGroupMembershipRemoval resources. Specifically, it ensures that when a Contact uses a SubjectRef with APIGroup set to resourcemanager.miloapis.com, any associated membership or membership removal resource must be created in the same namespace as the referenced Contact.
This change enforces stricter scoping rules, improves organizational consistency, and prevents accidental misplacement or orphaning of membership and membership removal resources.